From 08cdbfe7b6629f71f23bbe31ddd3b92c832b918e Mon Sep 17 00:00:00 2001 From: Aaron van Geffen Date: Sun, 14 Jan 2024 20:22:23 +0100 Subject: [PATCH] ViewPhotoAlbum: move some logic into new prepareHeaderBox method --- controllers/ViewPhotoAlbum.php | 38 +++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/controllers/ViewPhotoAlbum.php b/controllers/ViewPhotoAlbum.php index 6524c86..139b560 100644 --- a/controllers/ViewPhotoAlbum.php +++ b/controllers/ViewPhotoAlbum.php @@ -26,23 +26,7 @@ class ViewPhotoAlbum extends HTMLController $tag = Tag::fromSlug($_GET['tag']); $id_tag = $tag->id_tag; $title = $tag->tag; - $description = !empty($tag->description) ? $tag->description : ''; - - // Can we go up a level? - if ($tag->id_parent != 0) - { - $ptag = Tag::fromId($tag->id_parent); - $back_link = BASEURL . '/' . (!empty($ptag->slug) ? $ptag->slug . '/' : ''); - $back_link_title = 'Back to "' . $ptag->tag . '"'; - } - elseif ($tag->kind === 'Person') - { - $back_link = BASEURL . '/people/'; - $back_link_title = 'Back to "People"'; - $is_person = true; - } - - $header_box = new AlbumHeaderBox($title, $description, $back_link, $back_link_title); + $header_box = $this->getHeaderBox($tag); } // View the album root. else @@ -198,6 +182,26 @@ class ViewPhotoAlbum extends HTMLController return $buttons; } + private function getHeaderBox(Tag $tag) + { + // Can we go up a level? + if ($tag->id_parent != 0) + { + $ptag = Tag::fromId($tag->id_parent); + $back_link = BASEURL . '/' . (!empty($ptag->slug) ? $ptag->slug . '/' : ''); + $back_link_title = 'Back to "' . $ptag->tag . '"'; + } + elseif ($tag->kind === 'Person') + { + $back_link = BASEURL . '/people/'; + $back_link_title = 'Back to "People"'; + $is_person = true; + } + + $description = !empty($tag->description) ? $tag->description : ''; + return new AlbumHeaderBox($tag->tag, $description, $back_link, $back_link_title); + } + public function __destruct() { if (isset($this->iterator))