Public/pics
2
2
Fork 2
Code Issues 6 Pull Requests 2 Releases Wiki Activity

GenericTable: drop $tableIsSortable property

Browse Source
This commit is contained in:
Aaron van Geffen 2024-12-19 12:01:00 +01:00
parent e57289eeb6
commit 06c95853f5
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
models/GenericTable.php
View File

@ -15,7 +15,6 @@ class GenericTable
private $title; private $title;
private $title_class; private $title_class;
private $tableIsSortable = false;
public $form_above; public $form_above;
public $form_below; public $form_below;
@ -37,9 +36,6 @@ class GenericTable
if (!empty($options['sort_direction']) && !in_array($options['sort_direction'], ['up', 'down'])) if (!empty($options['sort_direction']) && !in_array($options['sort_direction'], ['up', 'down']))
$options['sort_direction'] = 'up'; $options['sort_direction'] = 'up';
// Make sure we know whether we can actually sort on something.
$this->tableIsSortable = !empty($options['base_url']);
// How much data do we have? // How much data do we have?
$this->recordCount = $options['get_count'](); $this->recordCount = $options['get_count']();
@ -100,7 +96,7 @@ class GenericTable
if (empty($column['header'])) if (empty($column['header']))
continue; continue;
$isSortable = $this->tableIsSortable && !empty($column['is_sortable']); $isSortable = !empty($column['is_sortable']);
$sortDirection = $key == $this->sort_order && $this->sort_direction === 'up' ? 'down' : 'up'; $sortDirection = $key == $this->sort_order && $this->sort_direction === 'up' ? 'down' : 'up';
$header = [ $header = [