Commit Graph

114 Commits

Author SHA1 Message Date
6150922a1f ErrorHandler: fix longstanding typo, occur*r*ed 2023-12-14 21:14:09 +01:00
efb35cfd6a PhotoMosaic: add sixLandscapes layout, combining side and row 2023-12-02 01:29:11 +01:00
d42c3c142c PhotosIndex: differentiate dual/single layouts by landscape/portrait 2023-12-02 00:50:04 +01:00
d45b467bb1 PhotoMosaic: rewrite getRow to use availableLayouts 2023-12-02 00:24:43 +01:00
8700fc1417 PhotoMosaic: introduce availableLayouts method 2023-12-01 23:41:05 +01:00
b98785d7b2 PhotoMosaic: remove unused getRecentPhotos method 2023-12-01 23:39:55 +01:00
8e0e642d34 PhotoMosaic: reorder methods to be alphabetically ordered 2023-12-01 22:47:51 +01:00
aeaff887ca Merge pull request 'Asset: let slugs consist only of an explicit set of allowed characters' (#41) from clean-slugs into master
Reviewed-on: #41
2023-11-22 16:03:54 +01:00
baa928531b Asset: let slugs consist only of an explicit set of allowed characters 2023-11-20 22:45:48 +01:00
65ee07d95b Session: centralise how session tokens are handled 2023-11-20 20:59:35 +01:00
5f778d73b4 Session: remove checks for matching IP address and user agent
This was considered good practice in the days before always-on https,
but is considered superfluous today. It even gets in the way of IPv6
privacy extensions, which is the main argument for removing them today.
2023-11-20 20:58:20 +01:00
0c861bf976 EditAsset: allow changing an asset's parent album 2023-11-12 17:26:03 +01:00
0c13a39d04 Image: don't re-queue thumbnails when deleting them 2023-11-11 15:34:45 +01:00
e28fcd8b03 Move photo deletion from ViewPhoto to EditAsset
Removes the intermediate confirmation page, instead using JavaScript for confirmation.

Fixes an XSS issue, in that the previous method was not passing or checking the session (!)
2023-11-11 15:29:32 +01:00
83da4a26ac EditAsset: allow users to edit their own photos 2023-11-11 15:14:57 +01:00
03ad26655c Remove unused Cache class
Kabuki CMS uses a Cache class to cache objects using APCU, but Pics has never used it.
2023-06-06 12:25:36 +02:00
6930c0a06a Misc: use the correct copyright headers 2023-04-08 21:32:38 +02:00
ed07668b2e Database: connect using utf8mb4 2023-04-08 14:54:55 +02:00
be909bf54d PhotosIndex: rename 'row' layout to 'landscapes' 2023-04-01 14:41:24 +02:00
68ef80fb9f PhotoMosaic: improve heuristic for landscape/portrait row 2023-04-01 14:40:19 +02:00
a260f4ff88 ErrorHandler: use var_export for dumping superglobals as well 2023-03-28 19:21:19 +02:00
2a528f2830 ErrorHandling: improve argument handling for debug info
`var_dump` was the wrong function to call for objects, as it would just output all object
data to the output buffer... Let's generalise and use `var_export` instead :-)
2023-03-28 19:21:07 +02:00
b2bcb6a124 Fix error handling for functions without arguments 2023-03-15 09:49:55 +01:00
d1741f2478 User: less strict typing for $reset_key property 2023-03-14 21:22:35 +01:00
41881594e9 PhotoMosaic: make photo order more intuitive 2023-03-12 12:34:47 +01:00
29bf6af1f8 Asset: delete thumbnails when deleting an assets 2023-03-12 12:21:43 +01:00
244af88a9a Asset: cleaner handling of conflicting filenames 2023-03-12 12:02:21 +01:00
3cf281b24d AdminMenu: add error count to badge iff count > 0 2023-03-12 01:04:28 +01:00
1b7e745f11 Clean up Tag::resetIdAsset 2023-03-11 21:41:23 +01:00
aa3a54f237 Asset: guard using property_exists in constructor 2023-03-11 21:39:20 +01:00
a76dde927b AccountSettings: list tags owned by current user 2023-03-11 20:27:09 +01:00
ad816f10a3 EditTag: allow designating a tag owner 2023-03-11 19:57:19 +01:00
6d0aef4df6 EditTag: allow updating the thumbnail visually 2023-03-11 19:49:17 +01:00
4684482d67 ManageAlbums: move hierarchy logic to PhotoAlbum model 2023-03-11 17:28:21 +01:00
02b43035f3 AccountSettings: allow users to change their personal details 2023-03-11 15:32:07 +01:00
277611e0ac Introduce new menu classes and navigation templates 2023-03-11 15:14:05 +01:00
0366df9b5f Alerts: replace 'error' class with 'danger' 2023-03-11 13:30:02 +01:00
f9eefe7b41 Replace generic alert, form and table templates with new Bootstrap equivalents 2023-03-11 13:20:59 +01:00
09f498695d Router: split off from Dispatcher 2023-01-01 19:48:19 +01:00
4d05cebc40 PhotoMosaic: address deprecation notice in usort call 2022-12-25 14:06:54 +01:00
7897172256 Address dynamic class property deprecation warnings 2022-12-25 13:56:42 +01:00
49390c372d Use triple-equals in a few more places 2022-12-25 13:50:03 +01:00
2174e1d08b PhotoPage: show software used to edit photo 2022-12-25 13:44:19 +01:00
3de87809bb GenericTable: prevent passing NULL to strtotime 2022-07-14 16:45:32 +02:00
c763967463 Prevent current page from being 0 if no items are present 2022-07-14 16:45:17 +02:00
b3808144ca Address deprecation notices for certain function signatures 2022-07-08 23:52:03 +02:00
d8858c78bb Thumbnails: crop from original size if 2x is unavailable 2022-07-07 14:54:00 +02:00
c0d69f7205 Do not delete thumbnail queue when replacing an asset
Thumbnails are normally created on demand, e.g. when processing the format codes in a post's body text.
Normally, the temporary URL is only used once to generate thumbnails ad-hoc. However, when cache is
enabled, a reference to the asset may be used in a cached version of a formatted body text, skipping
the normal thumbnail generation routine.

When an asset is replaced, currently, all thumbnails are removed and references to them are removed
from the database. In case the asset is still referenced in a cached formatted body text, this could lead
to an error when requesting the thumbnail, as the thumbnail request is no longer present in the system.

As we do not know what posts use particular assets at this point in the code, it is best to work around this
issue by unsetting the thumbnail filenames rather than deleting the entries outright. This effectively
generates them again on the next request.

In the future, we should aim to keep track of what posts make use of assets, so cache may be invalidated
in a more targeted way.
2022-07-07 14:22:22 +02:00
b5edf09a69 Don't try to generate double-density thumbs for small images 2022-07-07 14:05:33 +02:00
54fb7ab410 Write new thumbnail filenames to parent Image object as well 2022-07-07 13:55:55 +02:00