Add double-density support to photo thumbnails #28

Aaron · 2022-07-08T23:51:28+02:00

Aaron commented

2022-07-08 23:51:28 +02:00

This PR introduces double-density thumbnails to album indices and photo pages. Part of the thumbnail generation code has been refactored for readability as well.

Aaron added 11 commits 2022-07-08 23:51:29 +02:00

Add Image::getInlineImage method 357d95f6ff

Rewrite Image::getInlineImage to support double density displays edfad992cc

Split Image::getImageUrls from Image::getInlineImage 2bcdc5fe6e

Thumbnail class: refactor getUrl method e3b67c4022

Thumbnail class: minor refactor of generate method 9010123d18

Write new thumbnail filenames to parent Image object as well 44bb501d13

Don't try to generate double-density thumbs for small images 36a2779381

Do not delete thumbnail queue when replacing an asset 58b7204fbf

Thumbnails are normally created on demand, e.g. when processing the format codes in a post's body text.
Normally, the temporary URL is only used once to generate thumbnails ad-hoc. However, when cache is
enabled, a reference to the asset may be used in a cached version of a formatted body text, skipping
the normal thumbnail generation routine.

When an asset is replaced, currently, all thumbnails are removed and references to them are removed
from the database. In case the asset is still referenced in a cached formatted body text, this could lead
to an error when requesting the thumbnail, as the thumbnail request is no longer present in the system.

As we do not know what posts use particular assets at this point in the code, it is best to work around this
issue by unsetting the thumbnail filenames rather than deleting the entries outright. This effectively
generates them again on the next request.

In the future, we should aim to keep track of what posts make use of assets, so cache may be invalidated
in a more targeted way.

Thumbnails: crop from original size if 2x is unavailable 64d7433a56

Address deprecation notices for certain function signatures 12407d797d

Add double-density thumbnails to albums and photo pages 474c387786

Aaron added 2 commits 2022-07-14 16:40:37 +02:00

Prevent current page from being 0 if no items are present 8414843bbf

GenericTable: prevent passing NULL to strtotime 187a7cd02f

Aaron force-pushed improve_thumbs from 187a7cd02f to 3de87809bb

2022-11-27 14:36:32 +01:00

Compare

Aaron merged commit d66f071aab into master

2022-11-27 14:38:22 +01:00

Aaron referenced this issue from a commit