Public/pics
2
2
Fork 2
Code Issues 6 Pull Requests 2 Releases Wiki Activity

Allow users to filter albums by contributors #48

Merged
Roflin merged 18 commits from refactor/viewalbum into master 2024-01-20 20:11:18 +01:00
Conversation 1 Commits 18 Files Changed 11 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5d990501f6 - Show all commits

6
controllers/ViewPhotoAlbum.php
View File

@ -89,8 +89,11 @@ class ViewPhotoAlbum extends HTMLController
$this->page->adopt($index); $this->page->adopt($index);
} }
// Are we viewing a person tag?
$is_person = $tag->kind === 'Person';
Aaron marked this conversation as resolved Outdated
minnozz commented 2024-01-15 09:56:38 +01:00
Outdated
Review
Copy Link

$is_person is never set

(At $employer we had the convention to always use !== null instead of isset when you expect the variable to exist to catch these kind of errors. empty() was also discouraged for this reason)

`$is_person` is never set (At $employer we had the convention to always use `!== null` instead of `isset` when you expect the variable to exist to catch these kind of errors. `empty()` was also discouraged for this reason)
Aaron commented 2024-01-15 11:28:27 +01:00
Outdated
Review
Copy Link

Yeah, I don't like this either. I've opted instead to explicitly declare it as a boolean before it's used.

Yeah, I don't like this either. I've opted instead to explicitly declare it as a boolean before it's used.
// Load a photo mosaic for the current tag. // Load a photo mosaic for the current tag.
list($mosaic, $total_count) = $this->getPhotoMosaic($id_tag, $id_user_uploaded, $current_page, !isset($is_person)); list($mosaic, $total_count) = $this->getPhotoMosaic($id_tag, $id_user_uploaded, $current_page, !$is_person);
if (isset($mosaic)) if (isset($mosaic))
{ {
$index = new PhotosIndex($mosaic, Registry::get('user')->isAdmin()); $index = new PhotosIndex($mosaic, Registry::get('user')->isAdmin());
@ -235,7 +238,6 @@ class ViewPhotoAlbum extends HTMLController
{ {
Aaron marked this conversation as resolved
minnozz commented 2024-01-15 09:54:14 +01:00
Review
Copy Link

Unused here

Unused here
$back_link = BASEURL . '/people/'; $back_link = BASEURL . '/people/';
$back_link_title = 'Back to "People"'; $back_link_title = 'Back to "People"';
$is_person = true;
} }
$description = !empty($tag->description) ? $tag->description : ''; $description = !empty($tag->description) ? $tag->description : '';