electricdusk
/
rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Bad Accept header results in internal server error #66

New Issue
Closed
opened 2020-06-28 14:43:55 +02:00 by electricdusk · 2 comments
electricdusk commented 2020-06-28 14:43:55 +02:00
Owner
Copy Link

See https://hashru.link/Qd_z.

In this case, the client (presumably) provided a bad Accept header. In this case, rushlink should error with an 400 Bad Request error. However, it fails with an internal server error.

See <https://hashru.link/Qd_z>. In this case, the client (presumably) provided a bad `Accept` header. In this case, rushlink should error with an `400 Bad Request` error. However, it fails with an internal server error.
electricdusk added the
bug
needs-test
good-beginner-bug
 labels 2020-06-28 14:43:55 +02:00
electricdusk commented 2020-07-06 17:53:17 +02:00
Author
Owner
Copy Link

This error seems to occur when the client's Accept value has a leading white space. By the spec, this should be trimmed however.

This error seems to occur when the client's `Accept` value has a leading white space. By the spec, this should be trimmed however.
electricdusk commented 2020-07-06 17:56:03 +02:00
Author
Owner
Copy Link

However, a media-range value '*' is still invalid, I think.

However, a `media-range` value `'*'` is still invalid, I think.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
sql
Labels
Clear labels   
bug

Uninteded behaviour

  
feature

Request for a feature to be implemented

  
good-beginner-bug

Bugs are probably easy to fix

  
needs-test

Needs a regression test

  
question

Question about the software

  
wontfix

Wont be resolved

No Label
bug
feature
good-beginner-bug
needs-test
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#66
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?