electricdusk/rushlink
3
3 Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Should a link to an uploaded file redirect to /uploads/<hash>/filename.ext, or serve the file directly? #28

New Issue
Closed
opened 2019-12-13 15:04:13 +01:00 by minnozz · 4 comments
minnozz commented 2019-12-13 15:04:13 +01:00
Collaborator
Copy link
Copy source

Currently, https://hashru.link/PVwZ, which is a file uploaded with -F'file=@filename.ext', redirects to https://hashru.link/uploads/ef9841a5d7fb4917ab7dea052329e5f4/dancing-baby.gif, which serves the file.

Alternatively, we could serve the file directly, keeping https://hashru.link/PVwZ in the address bar of the user's browser.

Currently, `https://hashru.link/PVwZ`, which is a file uploaded with `-F'file=@filename.ext'`, redirects to `https://hashru.link/uploads/ef9841a5d7fb4917ab7dea052329e5f4/dancing-baby.gif`, which serves the file. Alternatively, we could serve the file directly, keeping `https://hashru.link/PVwZ` in the address bar of the user's browser.
electricdusk commented 2019-12-13 16:56:47 +01:00
Owner
Copy link
Copy source

The reason I chose for this design is to allow the administrator to easily delegate the serving of the files to the webserver, instead of the Go process. However, to do this properly, we really want to separate the paths, s.t. you can tell the webserver to handle/cache the files immediately.

The reason I chose for this design is to allow the administrator to easily delegate the serving of the files to the webserver, instead of the Go process. However, to do this properly, we really want to separate the paths, s.t. you can tell the webserver to handle/cache the files immediately.
electricdusk added the question label 2019-12-13 16:57:16 +01:00
electricdusk commented 2019-12-15 09:41:42 +01:00
Owner
Copy link
Copy source

Closing as "question answered". Feel free to reopen if something is still unclear.

Closing as "question answered". Feel free to reopen if something is still unclear.
minnozz commented 2019-12-16 09:58:33 +01:00
Author
Collaborator
Copy link
Copy source

For future reference, this is the way to implement this in nginx (the X-Accel-Redirect header): https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/

For future reference, this is the way to implement this in nginx (the `X-Accel-Redirect` header): https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/
👍 1
electricdusk added the feature label 2019-12-19 22:34:22 +01:00
electricdusk commented 2019-12-19 22:34:45 +01:00
Owner
Copy link
Copy source

I decided that we should implement this, mainly because CURL does not follow redirects by default.

I decided that we should implement this, mainly because CURL does not follow redirects by default.
electricdusk removed the question label 2019-12-19 22:34:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Uninteded behaviour
 feature
Request for a feature to be implemented
 good-beginner-bug
Bugs are probably easy to fix
 needs-test
Needs a regression test
 question
Question about the software
 wontfix
Wont be resolved
No labels feature
Milestone
No items
No Milestone
Assignees
Clear assignees
mara minnozz (Bart Schuurmans) mrngm electricdusk (Amber Sprenkels)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electricdusk/rushlink#28