Fragment identifier not parsed when shortening an URL #45

New Issue

Closed

opened 2020-04-22 16:10:09 +02:00 by electricdusk · 0 comments

electricdusk commented 2020-04-22 16:10:09 +02:00

Owner

Copy link

Copy source

For example, when shortening https://example.com/#SomeID, rushlink will actually parse https://example.com/%23SomeID.

For example, when shortening `https://example.com/#SomeID`, rushlink will actually parse `https://example.com/%23SomeID`.

electricdusk referenced this issue from a commit 2020-04-22 16:12:55 +02:00

User url.Parse instead of url.ParseRequestURI url.ParseRequestURI assumes the URL does not contain a fragment identifier. However, this is not disallowed. So we should use url.Parse instead. Related issue: #45

electricdusk added the needs-test label 2020-04-22 16:13:01 +02:00

electricdusk referenced this issue from a commit 2020-04-22 18:26:22 +02:00

Add a test for issue #45

electricdusk referenced this issue 2020-04-22 18:29:22 +02:00

Add a test for issue #45; NFC #46

electricdusk added the bug label 2020-04-22 20:49:54 +02:00

electricdusk referenced this issue from a commit 2020-04-27 12:59:53 +02:00

Add a test for issue #45; NFC Fixes #45

electricdusk closed this issue 2020-04-27 13:00:31 +02:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

sql

No results found.

Labels

Clear labels

bug

Uninteded behaviour

feature

Request for a feature to be implemented

good-beginner-bug

Bugs are probably easy to fix

needs-test

Needs a regression test

question

Question about the software

wontfix

Wont be resolved

No labels bug needs-test

Milestone

No items

No Milestone

Assignees

Clear assignees

mara minnozz (Bart Schuurmans) mrngm electricdusk (Amber Sprenkels)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#45