Fixes the infinite loop and refactores some statechanges into useEffect hooks

This commit is contained in:
2022-05-01 17:41:14 +02:00
parent 2cfaf2b4cc
commit 0a214ca388
6 changed files with 68 additions and 49 deletions

View File

@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
function AddGameNight(props) {
const [expanded, setExpanded] = useState(false);
@@ -9,6 +9,12 @@ function AddGameNight(props) {
props.onChange({
game: gameName,
datetime: date
}).then((result) => {
if(result) {
setExpanded(false);
setGameName("");
setDate(null);
}
});
event.preventDefault();
};
@@ -21,6 +27,13 @@ function AddGameNight(props) {
setDate(event.target.value);
};
useEffect(() => {
if(!expanded) {
setGameName("");
setDate(null);
}
}, [expanded]);
if(expanded) {
return (
<div className="Add-GameNight">
@@ -32,20 +45,20 @@ function AddGameNight(props) {
<input id="gamename" name="gamename" type="text"
value={gameName}
onChange={handleNameChange} />
<label for="date">date:</label>
<input id="date" name="date" type="date"
<label for="datetime">date:</label>
<input id="datetime" name="datetime" type="datetime-local"
value={date}
onChange={handleDateChange} />
<input type="submit" value="Submit" />
</fieldset>
</form>
<button onClick={() => {setExpanded(false)}}>Expand</button>
<button onClick={() => setExpanded(false)}>Discard</button>
</div>
);
} else {
return (
<button onClick={() => {setExpanded(true)}}>Expand</button>
<button onClick={() => setExpanded(true)}>Expand</button>
);
}
}

View File

@@ -2,14 +2,10 @@ import React from 'react';
function Gamenights(props) {
console.log(props.gamenights);
let gamenights = props.gamenights.map(g =>
(<li>{g.game}</li>)
);
console.log(gamenights);
return (
<ul>
{gamenights}

View File

@@ -7,7 +7,7 @@ function MenuBar(props) {
<a>Gamenight</a>
</li>
<li>
<a>User: {props.user}</a>
<a>User: {props.user.username}</a>
</li>
<li>
<button onClick={props.onLogout}>Logout</button>