Rework album/tag downloads #19

2020-03-11T12:37:16+01:00

Aaron commented

2020-03-11 12:37:16 +01:00

The previous download implementation was hampered by PHP's output buffer, leading to a maximum tar of approximately 62MB on my local setup. The last commit in this PR explicitly disables output buffering before writing tar output.

This further changes the blocking routine to work on a per-session basis, instead of using a global lock file. In case something goes sour, still, the user can just log out and in again to try again.

Presented as an alternative to #18

The previous download implementation was hampered by PHP's output buffer, leading to a maximum tar of approximately 62MB on my local setup. The last commit in this PR explicitly disables output buffering before writing `tar` output. This further changes the blocking routine to work on a per-session basis, instead of using a global lock file. In case something goes sour, still, the user can just log out and in again to try again. Presented as an alternative to #18

Roflin reviewed

2020-03-11 12:50:26 +01:00

controllers/Download.php

						
				@@ -23,3 +23,2 @@

						if($album->kind !== 'Album')

							throw new UnexpectedValueException('Specified tag does not correspond to an album');

						if (isset($_SESSION['current_export']))