Public
/
pics
2
2
Fork 2
Code Issues 6 Pull Requests Releases Wiki Activity

Rework album/tag downloads #19

Merged
Roflin merged 6 commits from tag-download into master 2020-03-11 20:04:31 +01:00
Conversation 0 Commits 6 Files Changed 1 +51 -51
Aaron commented 2020-03-11 12:37:16 +01:00
Member
Copy Link

The previous download implementation was hampered by PHP's output buffer, leading to a maximum tar of approximately 62MB on my local setup. The last commit in this PR explicitly disables output buffering before writing tar output.

This further changes the blocking routine to work on a per-session basis, instead of using a global lock file. In case something goes sour, still, the user can just log out and in again to try again.

Presented as an alternative to #18

The previous download implementation was hampered by PHP's output buffer, leading to a maximum tar of approximately 62MB on my local setup. The last commit in this PR explicitly disables output buffering before writing `tar` output. This further changes the blocking routine to work on a per-session basis, instead of using a global lock file. In case something goes sour, still, the user can just log out and in again to try again. Presented as an alternative to #18
Roflin reviewed 2020-03-11 12:50:26 +01:00
controllers/Download.php
@ -23,3 +23,2 @@
if($album->kind !== 'Album')
throw new UnexpectedValueException('Specified tag does not correspond to an album');
if (isset($_SESSION['current_export']))
Roflin commented 2020-03-11 12:50:24 +01:00
Owner
Copy Link

Ik zie deze check, maar ik zie niet waar deze session variable geset word? Of mis ik iets.

Ik zie deze check, maar ik zie niet waar deze session variable geset word? Of mis ik iets.
Aaron commented 2020-03-11 17:11:45 +01:00
Author
Member
Copy Link

Oef, terecht. Ik vermoed dat ik die ben verloren in een overijverige rebase. Gaan we fixen.

Oef, terecht. Ik vermoed dat ik die ben verloren in een overijverige rebase. Gaan we fixen.
Roflin closed this pull request 2020-03-11 20:04:30 +01:00
Aaron deleted branch tag-download 2020-03-11 22:44:55 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Public/pics#19
No description provided.
Delete Branch "tag-download"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?