Public/pics
2
2
Fork 2
Code Issues 6 Pull Requests Releases Wiki Activity

Photo uploader: reduce client memory usage #15

Merged
Roflin merged 1 commits from uploader-optimisation into master 2020-02-25 13:30:49 +01:00
Conversation 1 Commits 1 Files Changed 1 +28 -7
Aaron commented 2020-02-08 20:41:25 +01:00
Member
Copy Link

To create inline thumbnails locally, the previous version of the photo uploader used base64 representations of the local files to be uploaded. While this is effective, it is a little wasteful. When uploading several photos at once, this could even lead to the page becoming less responsive.

This PR changes the process such that the photos are actually resized on a canvas, only using the local original as a buffer. Hence, only the resized photo is retained in memory.

To create inline thumbnails locally, the previous version of the photo uploader used base64 representations of the local files to be uploaded. While this is effective, it is a little wasteful. When uploading several photos at once, this could even lead to the page becoming less responsive. This PR changes the process such that the photos are actually resized on a canvas, only using the local original as a buffer. Hence, only the resized photo is retained in memory.
Roflin approved these changes 2020-02-25 13:28:24 +01:00
Roflin closed this pull request 2020-02-25 13:30:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Roflin
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Aaron minnozz mrngm Roflin yorick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Public/pics#15
No description provided.
Delete Branch "uploader-optimisation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?