Refactor generic tables and page index classes #26

Aaron · 2021-02-17T20:50:36+01:00

Aaron commented

2021-02-17 20:50:36 +01:00

The generic tables and page index classes were separately usable, but more intertwined than what constitutes good OO design. This PR merges the changes from upstream Kabuki, addressing this. The public facing functions have not changed.

(There's a history behind this, of course, but that's a story for another day. Needless to say I am happy to get this off my todo list.)

The generic tables and page index classes were separately usable, but more intertwined than what constitutes good OO design. This PR merges the changes from upstream Kabuki, addressing this. The public facing functions have not changed. (There's a history behind this, of course, but that's a story for another day. Needless to say I am happy to get this off my todo list.)

Aaron added 8 commits 2021-02-17 20:50:37 +01:00

5c55e45c3c Use splat operator instead of call_user_func_array

96937b6952 Use null-coalescing operator where appropriate

cba42a9129 Refactor GenericTable to use PageIndex rather than inherit from it

This has on my todo list for years... I'm glad to finally get around to it.

681af07985 Pass builder function for custom pagination link generation.

This makes pagination for GenericTables work properly again.

af73f00701 Restrict access to GenericTable, Pagination class members.

6c662481bc Remove a few obscure, unused features.

* Removed support for row classification. Use of CSS is preferred.
* Removed support for disabling/enabling columns via a property. Unset as needed.
* Removed support for passing and inheriting a cell width by column. Header width suffices.

ff808ba18d Refactor processing of raw rows and their cell data.

4bf4641428 Minor refactor of generateColumnHeaders function

Aaron changed title from ~~Refactor generic tables and page index class~~ to Refactor generic tables and page index classes

2021-02-17 20:50:59 +01:00

Aaron added 1 commit 2021-02-17 22:43:55 +01:00

237f4005bd Apply htmlspecialchars to basic values.

Roflin approved these changes 2021-05-16 15:55:02 +02:00

Roflin merged commit 4863561129 into master

2021-05-17 20:19:18 +02:00

Roflin referenced this issue from a commit

2021-05-17 20:19:18 +02:00

Merge pull request 'Refactor generic tables and page index classes' (#26) from refactor-tables into master