Public/pics
2
2
Fork 2
Code Issues 6 Pull Requests 2 Releases Wiki Activity

PhotoMosaic: don't put portraits in landscape slots #38

Closed
minnozz wants to merge 1 commits from make-portrait-great-again into master
pull from: make-portrait-great-again
merge into: Public:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
minnozz commented 2023-11-16 17:32:45 +01:00
Member
Copy Link

This reverts commit 0d1fce41c8.

This prevents portrait photos from being assigned a cropped landscape slot in the mosaic, at the cost of the ordering being less chronological. Merge at your own discretion.

Fixes #9.

This reverts commit 0d1fce41c8e7173f3ef6cad3ab72bb5e4ab29953. This prevents portrait photos from being assigned a cropped landscape slot in the mosaic, at the cost of the ordering being less chronological. Merge at your own discretion. Fixes #9.
minnozz added 1 commit 2023-11-16 17:32:45 +01:00 
This reverts commit 0d1fce41c8.

This prevents portrait photos from being assigned a cropped landscape
slot in the mosaic, at the cost of the ordering being less
chronological.
Aaron commented 2023-11-16 20:49:13 +01:00
Member
Copy Link

I agree the original solution isn't the best, and really more of a workaround. However, I think reverting it isn't the right solution, either — for the same reason you've already mentioned. I expect it to lead to very confusing back/forward behaviour in the viewer.

Ideally, we'd change the initial heuristic outright. Instead of basing the content on the layout, it should really be the other way around. Yes, doing so will require more of a patch, but I think it's worth investing some time in that.

I agree the original solution isn't the best, and really more of a workaround. However, I think reverting it isn't the right solution, either — for the same reason you've already mentioned. I expect it to lead to very confusing back/forward behaviour in the viewer. Ideally, we'd change the initial heuristic outright. Instead of basing the content on the layout, it should really be the other way around. Yes, doing so will require more of a patch, but I think it's worth investing some time in that.
minnozz commented 2023-11-17 09:45:49 +01:00
Author
Member
Copy Link

All right, I'll close this :)

All right, I'll close this :)
minnozz closed this pull request 2023-11-17 09:45:49 +01:00
Aaron deleted branch make-portrait-great-again 2023-11-17 11:43:02 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Public/pics#38
No description provided.
Delete Branch "make-portrait-great-again"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?