Public/pics
2
2 Fork 3
Code Issues 5 Pull Requests 1 Releases Wiki Activity

Rework meta data display on photo page #45

Merged
minnozz merged 5 commits from photo-page into master 2024-01-13 17:23:06 +01:00
Conversation 2 Commits 5 Files Changed 4
+105 -121
Aaron commented 2024-01-11 19:20:58 +01:00
Member
Copy link
Copy source

Before/after screenshots attached.

Before/after screenshots attached.
pics_meta_before.png
1.2 MiB
pics_meta_after.png
1.9 MiB
pics_meta_before.png pics_meta_after.png
Aaron added 4 commits 2024-01-11 19:21:00 +01:00
PhotoPage: make prev/next photo logic more direct bc08e867f0
ViewPhoto: use class state to store Image object 55c33c024e
ViewPhoto: prepare meta data in controller; change layout e374f7ed59
PhotoPage: move user actions inside photo description box d17d98a838
minnozz approved these changes 2024-01-12 10:27:56 +01:00
minnozz left a comment
Member
Copy link
Copy source

Pretty!

Pretty!
controllers/ViewPhoto.php Outdated
@@ -86,0 +98,4 @@
$metaData['Shutter Speed'] = $exif->shutterSpeedFraction();
if (!empty($exif->aperture))
$metaData['Aperture'] = number_format($exif->aperture, 1);
minnozz commented 2024-01-12 10:26:11 +01:00
Member
Copy link
Copy source

Maybe re-add the f/ prefix?

Maybe re-add the `f/` prefix?
Aaron marked this conversation as resolved
controllers/ViewPhoto.php Outdated
@@ -86,0 +101,4 @@
$metaData['Aperture'] = number_format($exif->aperture, 1);
if (!empty($exif->focal_length))
$metaData['Focal Length'] = $exif->focal_length;
minnozz commented 2024-01-12 10:25:51 +01:00
Member
Copy link
Copy source

Maybe re-add the mm unit?

Maybe re-add the `mm` unit?
Aaron marked this conversation as resolved
Aaron added 1 commit 2024-01-12 10:38:11 +01:00
ViewPhoto: re-add accidentally omitted units b48f7dbb9e
Aaron commented 2024-01-12 10:38:44 +01:00
Author
Member
Copy link
Copy source

@minnozz Thanks, nice catches! I've re-added the accidentally omitted bits.

@minnozz Thanks, nice catches! I've re-added the accidentally omitted bits.
minnozz merged commit 0da1558bd3 into master 2024-01-13 17:23:06 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
minnozz
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
Aaron (Aaron van Geffen) minnozz (Bart Schuurmans) mrngm Roflin yorick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Public/pics#45