Public
/
pics
2
2
Fork 2
Code Issues 6 Pull Requests Releases Wiki Activity

Rework meta data display on photo page #45

Merged
minnozz merged 5 commits from photo-page into master 2024-01-13 17:23:06 +01:00
Conversation 1 Commits 5 Files Changed 4 +105 -121
Aaron commented 2024-01-11 19:20:58 +01:00
Member
Copy Link

Before/after screenshots attached.

Before/after screenshots attached.
pics_meta_before.png
1.2 MiB
pics_meta_after.png
1.9 MiB
pics_meta_before.png pics_meta_after.png
Aaron added 4 commits 2024-01-11 19:21:00 +01:00
minnozz approved these changes 2024-01-12 10:27:56 +01:00
minnozz left a comment
Member
Copy Link

Pretty!

Pretty!
controllers/ViewPhoto.php Outdated
@ -86,0 +98,4 @@
$metaData['Shutter Speed'] = $exif->shutterSpeedFraction();
if (!empty($exif->aperture))
$metaData['Aperture'] = number_format($exif->aperture, 1);
minnozz commented 2024-01-12 10:26:11 +01:00
Member
Copy Link

Maybe re-add the f/ prefix?

Maybe re-add the `f/` prefix?
Aaron marked this conversation as resolved
controllers/ViewPhoto.php Outdated
@ -86,0 +101,4 @@
$metaData['Aperture'] = number_format($exif->aperture, 1);
if (!empty($exif->focal_length))
$metaData['Focal Length'] = $exif->focal_length;
minnozz commented 2024-01-12 10:25:51 +01:00
Member
Copy Link

Maybe re-add the mm unit?

Maybe re-add the `mm` unit?
Aaron marked this conversation as resolved
Aaron added 1 commit 2024-01-12 10:38:11 +01:00
Aaron commented 2024-01-12 10:38:44 +01:00
Author
Member
Copy Link

@minnozz Thanks, nice catches! I've re-added the accidentally omitted bits.

@minnozz Thanks, nice catches! I've re-added the accidentally omitted bits.
minnozz merged commit 0da1558bd3 into master 2024-01-13 17:23:06 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
minnozz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Public/pics#45
No description provided.
Delete Branch "photo-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?