Rework meta data display on photo page #45

Aaron · 2024-01-11T19:20:58+01:00

Aaron commented

2024-01-11 19:20:58 +01:00

Before/after screenshots attached.

pics_meta_before.png

1.2 MiB

pics_meta_after.png

1.9 MiB

Aaron added 4 commits 2024-01-11 19:21:00 +01:00

PhotoPage: make prev/next photo logic more direct bc08e867f0

ViewPhoto: use class state to store Image object 55c33c024e

ViewPhoto: prepare meta data in controller; change layout e374f7ed59

PhotoPage: move user actions inside photo description box d17d98a838

minnozz approved these changes 2024-01-12 10:27:56 +01:00

minnozz left a comment

Pretty!

controllers/ViewPhoto.php Outdated

						
				@ -86,0 +98,4 @@

							$metaData['Shutter Speed'] = $exif->shutterSpeedFraction();

						if (!empty($exif->aperture))

							$metaData['Aperture'] = number_format($exif->aperture, 1);

minnozz commented

2024-01-12 10:26:11 +01:00

Maybe re-add the f/ prefix?

Maybe re-add the `f/` prefix?

Aaron marked this conversation as resolved

controllers/ViewPhoto.php Outdated

						
				@ -86,0 +101,4 @@

							$metaData['Aperture'] = number_format($exif->aperture, 1);

						if (!empty($exif->focal_length))

							$metaData['Focal Length'] = $exif->focal_length;