Public/pics
2
2
Fork 2
Code Issues 6 Pull Requests 2 Releases Wiki Activity

Rework meta data display on photo page #45

Merged
minnozz merged 5 commits from photo-page into master 2024-01-13 17:23:06 +01:00
Conversation 1 Commits 5 Files Changed 4 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b48f7dbb9e - Show all commits

4
controllers/ViewPhoto.php
View File

@ -98,10 +98,10 @@ class ViewPhoto extends HTMLController
$metaData['Shutter Speed'] = $exif->shutterSpeedFraction(); $metaData['Shutter Speed'] = $exif->shutterSpeedFraction();
if (!empty($exif->aperture)) if (!empty($exif->aperture))
$metaData['Aperture'] = number_format($exif->aperture, 1); $metaData['Aperture'] = 'f/' . number_format($exif->aperture, 1);
Aaron marked this conversation as resolved Outdated
minnozz commented 2024-01-12 10:26:11 +01:00
Outdated
Review
Copy Link

Maybe re-add the f/ prefix?

Maybe re-add the `f/` prefix?
if (!empty($exif->focal_length)) if (!empty($exif->focal_length))
$metaData['Focal Length'] = $exif->focal_length; $metaData['Focal Length'] = $exif->focal_length . ' mm';
Aaron marked this conversation as resolved Outdated
minnozz commented 2024-01-12 10:25:51 +01:00
Outdated
Review
Copy Link

Maybe re-add the mm unit?

Maybe re-add the `mm` unit?
if (!empty($exif->iso)) if (!empty($exif->iso))
$metaData['ISO Speed'] = $exif->iso; $metaData['ISO Speed'] = $exif->iso;