electricdusk/rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

[refactor] Review on #29 #30

New Issue
Open
opened 2019-12-16 11:53:42 +01:00 by electricdusk · 0 comments
electricdusk commented 2019-12-16 11:53:42 +01:00
Owner
Copy Link

This issue tracks the nits for #29, that should be fixed.

  • Has --host, but should rename to --root-url. (ffeb9a3362)
  • Should use the Forwarded and X-Forwarded headers as sensible default if present.
This issue tracks the nits for #29, that should be fixed. - [x] Has `--host`, but should rename to `--root-url`. (ffeb9a33625c3a15d22005f8c53b4064b61686e8) - [ ] Should use the `Forwarded` and `X-Forwarded` headers as sensible default if present. - [x] `X-Forwarded` (ffeb9a33625c3a15d22005f8c53b4064b61686e8) - [ ] `Forwarded`
electricdusk self-assigned this 2019-12-16 11:53:42 +01:00
electricdusk added the
bug
 label 2019-12-16 15:30:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Uninteded behaviour

  
feature

Request for a feature to be implemented

  
good-beginner-bug

Bugs are probably easy to fix

  
needs-test

Needs a regression test

  
question

Question about the software

  
wontfix

Wont be resolved

No Label
bug
feature
good-beginner-bug
needs-test
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
electricdusk
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#30
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?