[refactor] Review on #29 #30

New Issue

Open

opened 2019-12-16 11:53:42 +01:00 by electricdusk · 0 comments

electricdusk commented 2019-12-16 11:53:42 +01:00

Owner

Copy link

Copy source

This issue tracks the nits for #29, that should be fixed.

• Has --host, but should rename to --root-url. (ffeb9a3362)
• Should use the Forwarded and X-Forwarded headers as sensible default if present.
  • X-Forwarded (ffeb9a3362)
  • Forwarded

This issue tracks the nits for #29, that should be fixed. - [x] Has `--host`, but should rename to `--root-url`. (ffeb9a33625c3a15d22005f8c53b4064b61686e8) - [ ] Should use the `Forwarded` and `X-Forwarded` headers as sensible default if present. - [x] `X-Forwarded` (ffeb9a33625c3a15d22005f8c53b4064b61686e8) - [ ] `Forwarded`

electricdusk self-assigned this 2019-12-16 11:53:42 +01:00

electricdusk added the bug label 2019-12-16 15:30:35 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

sql

No results found.

Labels

Clear labels

bug

Uninteded behaviour

feature

Request for a feature to be implemented

good-beginner-bug

Bugs are probably easy to fix

needs-test

Needs a regression test

question

Question about the software

wontfix

Wont be resolved

No labels bug

Milestone

No items

No Milestone

Assignees

Clear assignees

mara minnozz (Bart Schuurmans) mrngm electricdusk (Amber Sprenkels)

No Assignees electricdusk

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#30