electricdusk/rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Possible directory traversal in file upload #53

New Issue
Closed
opened 2020-05-12 18:08:39 +02:00 by electricdusk · 1 comment
electricdusk commented 2020-05-12 18:08:39 +02:00
Owner
Copy Link

This occurred when building the Android app. During an upload attempts:

2020-05-12 18:02:24.659 26849-26986/com.dsprenkels.rushlinkshare E/com.dsprenkels.rushlinkshare.ShareActivity$Companion$UploadImageIntentHandler: Upload failed, unexpected code: Response{protocol=h2, code=500, message=, url=https://hashru.link/}
2020-05-12 18:02:24.663 26849-26986/com.dsprenkels.rushlinkshare I/com.dsprenkels.rushlinkshare.ShareActivity$Companion$UploadImageIntentHandler: Response body: internal server error: creating fileUpload: creating file dir: mkdir /var/lib/rushlink/filestore/08d7086ea08240bbaf3b57a5f1c25f31/data/user/0/com.dsprenkels.rushlinkshare/cache: no such file or directory

This is quite serious, because it probably also means that .. is not stripped from any paths.

This occurred when building the Android app. During an upload attempts: ``` 2020-05-12 18:02:24.659 26849-26986/com.dsprenkels.rushlinkshare E/com.dsprenkels.rushlinkshare.ShareActivity$Companion$UploadImageIntentHandler: Upload failed, unexpected code: Response{protocol=h2, code=500, message=, url=https://hashru.link/} 2020-05-12 18:02:24.663 26849-26986/com.dsprenkels.rushlinkshare I/com.dsprenkels.rushlinkshare.ShareActivity$Companion$UploadImageIntentHandler: Response body: internal server error: creating fileUpload: creating file dir: mkdir /var/lib/rushlink/filestore/08d7086ea08240bbaf3b57a5f1c25f31/data/user/0/com.dsprenkels.rushlinkshare/cache: no such file or directory ``` This is quite serious, because it probably also means that `..` is not stripped from any paths.
electricdusk added the
bug
needs-test
 labels 2020-05-12 18:08:39 +02:00
electricdusk self-assigned this 2020-05-12 18:08:39 +02:00
mrngm commented 2020-05-12 19:37:03 +02:00
Collaborator
Copy Link

Fix deployed out-of-band. Patch follows.

Fix deployed out-of-band. Patch follows.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Uninteded behaviour

  
feature

Request for a feature to be implemented

  
good-beginner-bug

Bugs are probably easy to fix

  
needs-test

Needs a regression test

  
question

Question about the software

  
wontfix

Wont be resolved

No Label
bug
feature
good-beginner-bug
needs-test
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
electricdusk
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#53
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?