electricdusk/rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Add request logging to panic recovery #63

Merged
electricdusk merged 1 commits from issue-61 into master 2020-07-06 17:13:03 +02:00
Conversation 0 Commits 1 Files Changed 1 +5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5a39d6a37c - Show all commits

5
router.go
View File

@ -30,11 +30,15 @@ func (rl *rushlink) RootURL() *url.URL {
func (rl *rushlink) recoveryMiddleware(next http.Handler) http.Handler { func (rl *rushlink) recoveryMiddleware(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
logRequestInfo := func() {
log.Printf("in request: %v - %v %q %v", r.RemoteAddr, r.Method, r.RequestURI, r.Proto)
}
defer func() { defer func() {
mrngm commented 2020-06-28 13:12:06 +02:00
Outdated
Review
Copy Link

I don't see a reason why the source port needs to be chopped off. Besides, the net/http server guarantees (by means of documentation) that http.Request.RemoteAddr is filled using IP:port, so this check should not be necessary.

I don't see a reason why the source port needs to be chopped off. Besides, the `net/http` server guarantees (by means of documentation) that `http.Request.RemoteAddr` is filled using `IP:port`, so this check should not be necessary.
defer func() { defer func() {
if err := recover(); err != nil { if err := recover(); err != nil {
w.WriteHeader(500) w.WriteHeader(500)
log.Printf("error: panic while recovering from another panic: %v\n", err) log.Printf("error: panic while recovering from another panic: %v\n", err)
mrngm commented 2020-06-28 13:04:25 +02:00
Outdated
Review
Copy Link

log.Printf already registers the timestamp. What's the use of a second timestamp here?

`log.Printf` already registers the timestamp. What's the use of a second timestamp here?
logRequestInfo()
mrngm commented 2020-06-28 13:12:43 +02:00
Outdated
Review
Copy Link

Instead of '%s', you may use %q, which automatically quotes the supplied string.

Instead of `'%s'`, you may use `%q`, which automatically quotes the supplied string.
debug.PrintStack() debug.PrintStack()
fmt.Fprintf(w, "internal server error: %v\n", err) fmt.Fprintf(w, "internal server error: %v\n", err)
} }
@ -43,6 +47,7 @@ func (rl *rushlink) recoveryMiddleware(next http.Handler) http.Handler {
if err := recover(); err != nil { if err := recover(); err != nil {
w.WriteHeader(500) w.WriteHeader(500)
log.Printf("error: %v\n", err) log.Printf("error: %v\n", err)
logRequestInfo()
debug.PrintStack() debug.PrintStack()
rl.renderInternalServerError(w, r, err) rl.renderInternalServerError(w, r, err)
} }