electricdusk/rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Error with 400 Bad Request when both 'file' and 'shorten' set #65

Merged
electricdusk merged 2 commits from issue-56 into master 2020-07-06 17:14:40 +02:00
Conversation 1 Commits 2 Files Changed 2 +53 -12
electricdusk commented 2020-05-30 18:36:58 +02:00
Owner
Copy Link

This patch refactors rushlink.newPasteHandler and adds a check that at most one of the fields file and shorten is set.

For some reason, the Go multipart form API populates the form with duplicate values, when only a single one is provided by the client. So we cannot check if (for example) only one shorten was provided. In this case, I chose to select the first one.

Fixes #56.

This patch refactors `rushlink.newPasteHandler` and adds a check that at most one of the fields `file` and `shorten` is set. For some reason, the Go multipart form API populates the form with duplicate values, when only a single one is provided by the client. So we cannot check if (for example) only *one* `shorten` was provided. In this case, I chose to select the first one. Fixes #56.
minnozz was assigned by electricdusk 2020-05-30 18:36:58 +02:00
electricdusk commented 2020-07-06 17:14:33 +02:00
Author
Owner
Copy Link

I think this patch should be good. Merging without real review.

I think this patch should be good. Merging without real review.
electricdusk closed this pull request 2020-07-06 17:14:40 +02:00
electricdusk deleted branch issue-56 2020-07-06 17:14:51 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Uninteded behaviour

  
feature

Request for a feature to be implemented

  
good-beginner-bug

Bugs are probably easy to fix

  
needs-test

Needs a regression test

  
question

Question about the software

  
wontfix

Wont be resolved

No Label
bug
feature
good-beginner-bug
needs-test
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
minnozz
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#65
No description provided.
Delete Branch "issue-56"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?