electricdusk/rushlink
3
3 Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

[refactor] Review on #29 #31

New Issue
Closed
opened 2019-12-16 11:53:43 +01:00 by electricdusk · 1 comment
electricdusk commented 2019-12-16 11:53:43 +01:00
Owner
Copy link
Copy source

This issue tracks the nits for #29, that should be fixed.

  • Has --host, but should rename to --root-url.
  • Should use the Forwarded header for sensible default if present.
This issue tracks the nits for #29, that should be fixed. - [ ] Has `--host`, but should rename to `--root-url`. - [ ] Should use the `Forwarded` header for sensible default if present.
electricdusk self-assigned this 2019-12-16 11:53:43 +01:00
electricdusk added the bug label 2019-12-16 11:53:56 +01:00
electricdusk commented 2019-12-16 15:29:50 +01:00
Author
Owner
Copy link
Copy source

Duplicate of #30, added by crappy connection.

Duplicate of #30, added by crappy connection.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Uninteded behaviour
 feature
Request for a feature to be implemented
 good-beginner-bug
Bugs are probably easy to fix
 needs-test
Needs a regression test
 question
Question about the software
 wontfix
Wont be resolved
No labels bug
Milestone
No items
No Milestone
Assignees
Clear assignees
mara minnozz (Bart Schuurmans) mrngm electricdusk (Amber Sprenkels)
No Assignees electricdusk
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electricdusk/rushlink#31