electricdusk
/
rushlink
3
3
Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Add support for file uploading #16

Manually merged
mrngm merged 4 commits from dsprenkels/upload into master 2019-11-29 18:36:38 +01:00
Conversation 3 Commits 4 Files Changed 15 +493 -91
electricdusk commented 2019-11-10 19:10:41 +01:00
Owner
Copy Link
  • Uploading files
  • Shortening files
  • Resolving shortened urls to files
  • Downloading files
  • Deleting files
- [x] Uploading files - [x] Shortening files - [x] Resolving shortened urls to files - [x] Downloading files - [x] Deleting files
electricdusk commented 2019-11-10 19:11:47 +01:00
Author
Owner
Copy Link

After this PR is merged, I think we should look at how we could refactor the code. Most relevant: I think we should consider not putting all the handlers in the same file.

After this PR is merged, I think we should look at how we could refactor the code. Most relevant: I think we should consider not putting all the handlers in the same file.
electricdusk changed title from WIP: Add support for file uploading to Add support for file uploading 2019-11-22 18:42:03 +01:00
electricdusk commented 2019-11-22 18:42:35 +01:00
Author
Owner
Copy Link

@mrngm This PR should be done. You can take a look, if you like.

@mrngm This PR should be done. You can take a look, if you like.
mrngm requested changes 2019-11-29 18:24:04 +01:00
paste.go Outdated
@ -26,3 +28,1 @@
typeUndef pasteType = 0
typePaste = 1
typeRedirect = 2
pasteTypeUndef pasteType = 0
mrngm commented 2019-11-29 18:23:39 +01:00
Collaborator
Copy Link

See below comment

See below comment
paste.go Outdated
@ -32,3 +35,1 @@
stateUndef pasteState = 0
statePresent = 1
stateDeleted = 2
pasteStateUndef pasteState = 0
mrngm commented 2019-11-29 18:23:28 +01:00
Collaborator
Copy Link

The type of the other states is not pasteState, see https://play.golang.org/p/lVjTWBgRQU-

The type of the other states is not `pasteState`, see https://play.golang.org/p/lVjTWBgRQU-
mrngm commented 2019-11-29 18:36:30 +01:00
Collaborator
Copy Link

With the changes I just pushed, this LGTM.

With the changes I just pushed, this LGTM.
mrngm closed this pull request 2019-11-29 18:36:37 +01:00
mrngm closed this pull request 2019-11-29 18:36:38 +01:00
electricdusk deleted branch dsprenkels/upload 2019-12-03 20:47:26 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Uninteded behaviour

  
feature

Request for a feature to be implemented

  
good-beginner-bug

Bugs are probably easy to fix

  
needs-test

Needs a regression test

  
question

Question about the software

  
wontfix

Wont be resolved

No Label
bug
feature
good-beginner-bug
needs-test
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: electricdusk/rushlink#16
No description provided.
Delete Branch "dsprenkels/upload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?