electricdusk/rushlink
3
3 Fork 3
Code Issues 21 Pull Requests 2 Releases Activity

Add support for file uploading #16

Manually merged
mrngm merged 4 commits from dsprenkels/upload into master 2019-11-29 18:36:38 +01:00
Conversation 4 Commits 4 Files Changed 15
+493 -91
electricdusk commented 2019-11-10 19:10:41 +01:00
Owner
Copy link
Copy source
  • Uploading files
  • Shortening files
  • Resolving shortened urls to files
  • Downloading files
  • Deleting files
- [x] Uploading files - [x] Shortening files - [x] Resolving shortened urls to files - [x] Downloading files - [x] Deleting files
electricdusk commented 2019-11-10 19:11:47 +01:00
Author
Owner
Copy link
Copy source

After this PR is merged, I think we should look at how we could refactor the code. Most relevant: I think we should consider not putting all the handlers in the same file.

After this PR is merged, I think we should look at how we could refactor the code. Most relevant: I think we should consider not putting all the handlers in the same file.
electricdusk marked the pull request as ready for review 2019-11-22 18:42:03 +01:00
electricdusk commented 2019-11-22 18:42:35 +01:00
Author
Owner
Copy link
Copy source

@mrngm This PR should be done. You can take a look, if you like.

@mrngm This PR should be done. You can take a look, if you like.
paste.go Outdated
@@ -26,3 +28,1 @@
typeUndef pasteType = 0
typePaste = 1
typeRedirect = 2
pasteTypeUndef pasteType = 0
mrngm commented 2019-11-29 18:23:39 +01:00
Collaborator
Copy link
Copy source

See below comment

See below comment
paste.go Outdated
@@ -32,3 +35,1 @@
stateUndef pasteState = 0
statePresent = 1
stateDeleted = 2
pasteStateUndef pasteState = 0
mrngm commented 2019-11-29 18:23:28 +01:00
Collaborator
Copy link
Copy source

The type of the other states is not pasteState, see https://play.golang.org/p/lVjTWBgRQU-

The type of the other states is not `pasteState`, see https://play.golang.org/p/lVjTWBgRQU-
mrngm commented 2019-11-29 18:36:30 +01:00
Collaborator
Copy link
Copy source

With the changes I just pushed, this LGTM.

With the changes I just pushed, this LGTM.
mrngm closed this pull request 2019-11-29 18:36:37 +01:00
mrngm closed this pull request 2019-11-29 18:36:38 +01:00
electricdusk deleted branch dsprenkels/upload 2019-12-03 20:47:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mrngm
Labels
Clear labels
bug
Uninteded behaviour
 feature
Request for a feature to be implemented
 good-beginner-bug
Bugs are probably easy to fix
 needs-test
Needs a regression test
 question
Question about the software
 wontfix
Wont be resolved
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
mara minnozz (Bart Schuurmans) mrngm electricdusk (Amber Sprenkels)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electricdusk/rushlink#16